Add illumos support to libc++ and LLVM.#61
Merged
alexey-milovidov merged 1 commit intoClickHouse:clickhouse1from Jan 5, 2026
Merged
Add illumos support to libc++ and LLVM.#61alexey-milovidov merged 1 commit intoClickHouse:clickhouse1from
alexey-milovidov merged 1 commit intoClickHouse:clickhouse1from
Conversation
libc++ changes: - Add __sun to pthread platforms and rune table providers. - Add illumos ctype mask definitions with non-overlapping __regex_word. - Use musl locale shim for missing *_l functions. - Skip overloads already defined in illumos stdlib. - Fix conflicting __sentinel, _E1-_E24 macros. LLVM changes: - Fix conflicting FS, CS/CE macros. - Use std::fabs instead of std::abs for float in SampleProfileProbe. Part of llvm#23777.
alexey-milovidov
approved these changes
Jan 5, 2026
Member
|
@jmcarp Was the code contributed to upstream LLVM? We (ClickHouse) better don't carry large patches in external libraries around. |
Member
|
That's a ticket from 2015. Typo? |
Author
|
Sorry, linked issue should be ClickHouse/ClickHouse#23777. And I'd be happy to submit this upstream. I'll take a look later this week, hopefully today. |
Member
|
Yes, upstreaming this would be great @jmcarp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add illumos support to libc++ and LLVM.
libc++ changes:
LLVM changes:
Part of llvm#23777.
cc @alexey-milovidov